Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DateRange CSS import #136

Merged
merged 6 commits into from
Dec 3, 2021
Merged

Fix DateRange CSS import #136

merged 6 commits into from
Dec 3, 2021

Conversation

MedElfadhelELHACHEMI
Copy link
Contributor

@MedElfadhelELHACHEMI MedElfadhelELHACHEMI commented Dec 2, 2021 •
edited by RoxBow
Loading

🎩 What? Why?

Since Next JS doesn't like importing CSS files from node_modules,
Nextjs Issue
i put all the CSS for react-dates in a styled-component object and deleted the css file import

📌 Related Issues

#10

🎨 Chromatic links

Chromatic PR
Storybook

@MedElfadhelELHACHEMI MedElfadhelELHACHEMI self-assigned this Dec 2, 2021
@MedElfadhelELHACHEMI MedElfadhelELHACHEMI marked this pull request as ready for review December 2, 2021 10:19
@MedElfadhelELHACHEMI MedElfadhelELHACHEMI requested a review from a team as a code owner December 2, 2021 10:19
@MedElfadhelELHACHEMI MedElfadhelELHACHEMI changed the title init Fix CSS import Dec 2, 2021
RoxBow
RoxBow reviewed Dec 2, 2021
View reviewed changes
src/components/form/dateRange/DateRange.module.tsx Outdated Show resolved Hide resolved
src/components/form/dateRange/DateRange.module.tsx Outdated Show resolved Hide resolved
src/components/form/dateRange/DateRange.module.tsx Outdated Show resolved Hide resolved
src/components/form/dateRange/DateRange.module.tsx Outdated Show resolved Hide resolved
src/components/form/dateRange/DateRange.stories.tsx Outdated Show resolved Hide resolved
src/components/form/dateRange/DateRange.tsx Outdated Show resolved Hide resolved
@RoxBow RoxBow changed the title Fix CSS import Fix DateRange CSS import Dec 2, 2021
RoxBow
RoxBow approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@RoxBow RoxBow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

size-limit report 📦

Path Size
dist/ui.cjs.production.min.js 231.18 KB (-0.36% 🔽)
dist/ui.esm.js 224.28 KB (-0.46% 🔽)

@MedElfadhelELHACHEMI MedElfadhelELHACHEMI merged commit 073c47a into master Dec 3, 2021
@MedElfadhelELHACHEMI MedElfadhelELHACHEMI deleted the fix-css-import branch December 3, 2021 10:43
@RoxBow RoxBow mentioned this pull request Dec 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoxBow RoxBow RoxBow approved these changes

Assignees

@MedElfadhelELHACHEMI MedElfadhelELHACHEMI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MedElfadhelELHACHEMI @RoxBow